It all works (I wrote it), but that issue is about consolidating some code for the future. We know there are going to need to be some changes made to the implementation of post flair once we start testing lemmy interoperability. So, that issue is essentially saying let’s write all the flair code in one place so that it’s easier to change in the future instead of having flair code duplicated between the api side and the web ui side of the piefed.